Set default processor allocation for test clusters#133204
Merged
jozala merged 2 commits intoelastic:mainfrom Aug 20, 2025
Merged
Set default processor allocation for test clusters#133204jozala merged 2 commits intoelastic:mainfrom
jozala merged 2 commits intoelastic:mainfrom
Conversation
Setting the number of processors available for node to adequately size thread pools. Related to elastic#130612
jozala
added
>non-issue
>test
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
requested changes
Aug 20, 2025
Contributor
breskeby
left a comment
breskeby
left a comment
There was a problem hiding this comment.
I think we can make this a bit more readable
| || buildParams.getBwcVersions().unreleasedInfo(version) == null | ||
| ); | ||
|
|
||
| NamedDomainObjectContainer<ElasticsearchCluster> testClusters = (NamedDomainObjectContainer<ElasticsearchCluster>) project |
Contributor
There was a problem hiding this comment.
I think we can simplify this a bit:
String processorCount = shouldConfigureTestClustersWithOneProcessor() ? "1" : "2";
NamedDomainObjectContainer<ElasticsearchCluster> testClusters = (NamedDomainObjectContainer<ElasticsearchCluster>) project
.getExtensions()
.getByName(TestClustersPlugin.EXTENSION_NAME);
testClusters.configureEach(elasticsearchCluster -> elasticsearchCluster.setting("node.processors", processorCount));
breskeby
approved these changes
Aug 20, 2025
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Aug 20, 2025
Setting the number of processors available for node to adequately size thread pools. Related to elastic#130612
This was referenced Aug 20, 2025
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Aug 20, 2025
Setting the number of processors available for node to adequately size thread pools. Related to elastic#130612
Collaborator
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Aug 20, 2025
Setting the number of processors available for node to adequately size thread pools. Related to elastic#130612
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Aug 20, 2025
Setting the number of processors available for node to adequately size thread pools. Related to elastic#130612
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Aug 20, 2025
Setting the number of processors available for node to adequately size thread pools. Related to elastic#130612
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Aug 20, 2025
…improv * upstream/main: (58 commits) Fixing flaky LoggedExec (tests) (elastic#133215) CPS search should not use `skip_unavailable` (elastic#132927) Don't fail search if bottom doc can't be formatted (elastic#133188) Mute org.elasticsearch.xpack.esql.action.RandomizedTimeSeriesIT testGroupByNothing elastic#133225 Mute org.elasticsearch.index.codec.tsdb.es819.ES819TSDBDocValuesFormatTests testSortedSetDocValuesWithSkipperSmall elastic#133224 Mute org.elasticsearch.index.codec.tsdb.es819.ES819TSDBDocValuesFormatTests testSortedNumberMergeAwayAllValuesWithSkipper elastic#133223 Adding support for index.number_of_replicas to data stream settings (elastic#132748) Mute org.elasticsearch.index.codec.tsdb.es819.ES819TSDBDocValuesFormatTests testSortedDocValuesSingleUniqueValue elastic#133221 Fix VectorSimilarityFunctionsIT (elastic#133206) Mute org.elasticsearch.xpack.esql.action.RandomizedTimeSeriesIT testGroupBySubset elastic#133220 Increase the number of FORK branches in ForkGenerator (elastic#132019) Mute org.elasticsearch.index.mapper.blockloader.IpFieldBlockLoaderTests testBlockLoader {preference=Params[syntheticSource=true, preference=STORED]} elastic#133218 Mute org.elasticsearch.index.mapper.blockloader.IpFieldBlockLoaderTests testBlockLoader {preference=Params[syntheticSource=true, preference=DOC_VALUES]} elastic#133217 Mute org.elasticsearch.index.mapper.blockloader.IpFieldBlockLoaderTests testBlockLoader {preference=Params[syntheticSource=true, preference=NONE]} elastic#133216 Set default processor allocation for test clusters (elastic#133204) Add mapper for exponential histograms (elastic#132493) Fix offset handling in Murmur3Hasher (elastic#133193) unmute testDoesNotResolveClosedIndex (elastic#133115) Fix an AWS SDK v2 release note (elastic#133155) Limit the depth of a filter (elastic#133113) ...
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Aug 20, 2025
* upstream/main: (58 commits) Fixing flaky LoggedExec (tests) (elastic#133215) CPS search should not use `skip_unavailable` (elastic#132927) Don't fail search if bottom doc can't be formatted (elastic#133188) Mute org.elasticsearch.xpack.esql.action.RandomizedTimeSeriesIT testGroupByNothing elastic#133225 Mute org.elasticsearch.index.codec.tsdb.es819.ES819TSDBDocValuesFormatTests testSortedSetDocValuesWithSkipperSmall elastic#133224 Mute org.elasticsearch.index.codec.tsdb.es819.ES819TSDBDocValuesFormatTests testSortedNumberMergeAwayAllValuesWithSkipper elastic#133223 Adding support for index.number_of_replicas to data stream settings (elastic#132748) Mute org.elasticsearch.index.codec.tsdb.es819.ES819TSDBDocValuesFormatTests testSortedDocValuesSingleUniqueValue elastic#133221 Fix VectorSimilarityFunctionsIT (elastic#133206) Mute org.elasticsearch.xpack.esql.action.RandomizedTimeSeriesIT testGroupBySubset elastic#133220 Increase the number of FORK branches in ForkGenerator (elastic#132019) Mute org.elasticsearch.index.mapper.blockloader.IpFieldBlockLoaderTests testBlockLoader {preference=Params[syntheticSource=true, preference=STORED]} elastic#133218 Mute org.elasticsearch.index.mapper.blockloader.IpFieldBlockLoaderTests testBlockLoader {preference=Params[syntheticSource=true, preference=DOC_VALUES]} elastic#133217 Mute org.elasticsearch.index.mapper.blockloader.IpFieldBlockLoaderTests testBlockLoader {preference=Params[syntheticSource=true, preference=NONE]} elastic#133216 Set default processor allocation for test clusters (elastic#133204) Add mapper for exponential histograms (elastic#132493) Fix offset handling in Murmur3Hasher (elastic#133193) unmute testDoesNotResolveClosedIndex (elastic#133115) Fix an AWS SDK v2 release note (elastic#133155) Limit the depth of a filter (elastic#133113) ...
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 22, 2025
…133213) * Set default processor allocation for test clusters (#133204) Setting the number of processors available for node to adequately size thread pools. Related to #130612 * Lowering the allocations during update to fit within available processors --------- Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 22, 2025
…133210) * Set default processor allocation for test clusters (#133204) Setting the number of processors available for node to adequately size thread pools. Related to #130612 * Lowering the allocations during update to fit within available processors --------- Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 22, 2025
…133209) * Set default processor allocation for test clusters (#133204) Setting the number of processors available for node to adequately size thread pools. Related to #130612 * Lowering the allocations during update to fit within available processors --------- Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co>
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Aug 25, 2025
Setting the number of processors available for node to adequately size thread pools. Related to elastic#130612
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Aug 25, 2025
Setting the number of processors available for node to adequately size thread pools. Related to elastic#130612
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 25, 2025
…133211) * Set default processor allocation for test clusters (#133204) Setting the number of processors available for node to adequately size thread pools. Related to #130612 * Lowering the allocations during update to fit within available processors --------- Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 25, 2025
…133212) * Set default processor allocation for test clusters (#133204) Setting the number of processors available for node to adequately size thread pools. Related to #130612 * Lowering the allocations during update to fit within available processors --------- Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co>
Member
|
For folks like me who are sometimes doing local benchmarking via |
Member
|
I'm also wondering if we could take an increased heap size (like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the number of processors available for node to adequately size thread pools.
Related to #130612